DM-37196: Modernize APDB schema #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-37196
branch
from
5f1253b
to
b1cef34
Compare
parejkoj
force-pushed
the
tickets/DM-37196
branch
from
c8e89ee
to
a169df9
Compare
parejkoj
force-pushed
the
tickets/DM-37196
branch
from
a169df9
to
a3c38c2
Compare
parejkoj
force-pushed
the
tickets/DM-37196
branch
3 times, most recently
from
df57191
to
ef4fe81
Compare
parejkoj
force-pushed
the
tickets/DM-37196
branch
from
6314ad2
to
a5d008a
Compare
* decl->dec in names * RA-Right Ascension and Decl->Declination in descriptions
This matches the middleware convention.
parejkoj
force-pushed
the
tickets/DM-37196
branch
2 times, most recently
from
5339722
to
bdd79a7
Compare
parejkoj
force-pushed
the
tickets/DM-37196
branch
from
bdd79a7
to
f52ef0c
Compare
ctslater
reviewed
May 31, 2023
| @@ -8812,7 +8885,7 @@ tables: | |||
| - name: llcra | |||
| '@id': '#CcdVisit.llcra' | |||
| datatype: double | |||
| description: RA of lower left corner. | |||
| description: Right Ascension of lower left corner. | |||
There was a problem hiding this comment.
No need to change this now, but I just realized how ambiguous "lower left corner" is (on the sky? which way is up on the camera?). Someday this should probably be "minimum y, minimum x" or some other way to express pixel coordinates.
There was a problem hiding this comment.
It may or may not help if we linked to the cameraGeom docs in these kinds of places, since we do have a self-consistent camera geometry definition.
https://pipelines.lsst.io/modules/lsst.afw.cameraGeom/cameraGeom.html#camera-coordinate-systems
validityStart/validityEnd are now processing time, not visit time.
Update description of DiaSource/DiaForcedSource versions to be explicit about where they are measured.
This is to have a record of what we've changed from the imsim.yaml definitions.
These fields are Visit level, not CcdVisit level: zenithDistance, skyRotation, expMidpt[MJD], expTime, obsStart, obsStart[MJD], darkTime, physical_filter, band. Move detector id to near the top of the list Cleanup CcdVisit descriptions and add punctuation.
This is a single-value table; we only ever include data from one instrument in a given APDB instance.
parejkoj
force-pushed
the
tickets/DM-37196
branch
from
f3a2e43
to
a5e9797
Compare
We've added `time_processed` as a much more explicit and easy to determine way to order DiaSources by when they were processed. This field was unused.
Also cleanup midPoint capitalization and expMidpt name. raDecTai->raDecMjdTai midPointMjd->midpointMjdTai obsStartMJD->objStartMjdTai expMidptMJD->midpointMjdTai expMidpt->midpoint
parejkoj
force-pushed
the
tickets/DM-37196
branch
from
a5e9797
to
2ece4c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.