DM-38507: Supply schema for the new ObsCore columns #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs_title is a standard-but-optional column and is planned for use in labeling images in the Portal display. lsst_ccdvisitid is a combination of lsst_visit and lsst_detector meant for use in accelerating JOINs with tables with a "ccdvisitid" column. Also: switch order of lsst_filter and lsst_visit to a more logical form, putting filter between the tract-patch columns and the visit-detector columns, since it applies to both systems.
Add table_index to the "ivoa.ObsCore" table. Update DP0.1 table indices to avoid the use of '0'. We're treating this as a reserved value in the validator.
fritzm
reviewed
Apr 13, 2023
| tap:column_index: 225 | ||
| ivoa:unit: | ||
| datatype: char | ||
| votable:arraysize: "*" |
There was a problem hiding this comment.
The underlying SQL type used for the in-place mod was VARCHAR(256) -- do we want votable:arraysize: 256 here to more closely represent that reality?
There was a problem hiding this comment.
No, I'm comfortable with the variable-length declaration. I'm rethinking this more generally.
fritzm
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also correct some of the existing validation errors.