Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38831: Initial DP0.3 schema #113

Merged
merged 2 commits into from May 1, 2023
Merged

DM-38831: Initial DP0.3 schema #113

merged 2 commits into from May 1, 2023

Conversation

ctslater
Copy link
Member

Only reflects preliminary data file schema with no modifications.

@fritzm
Copy link
Contributor

fritzm commented Apr 28, 2023

  • No mpcorb table?
  • Postgres tables as ingested are all lower-case (both table names and columns names; Postgres by default coerces all names to lowercase unless quoted.) If TAP quotes these mixed-case table and column names, I don't believe they will match...
  • Should we strip myqsql: attributes?

@ctslater
Copy link
Member Author

Thanks, all good points. I just pushed an MPCORB table. I don't think we need to do anything about the mysql attributes; felis will use those if you ask it to generate mysql DDL, but should ignore them otherwise.

The capitalization issue is pretty tricky. I'm kind of reluctant to convert these mostly-camelcase names all to lowercase. My memory is also that TAP quotes all identifiers.

@fritzm
Copy link
Contributor

fritzm commented Apr 28, 2023

[capitalization] I guess we can try and see? If everything ends up quoted, we'll have to rename everything already in Postgres to camelcase (ALTER TABLE; not particularly hard).

@fritzm fritzm self-requested a review April 28, 2023 14:59
@fritzm fritzm requested a review from gpdf April 28, 2023 15:00
@ctslater ctslater merged commit 50e13d6 into main May 1, 2023
2 of 3 checks passed
@ctslater ctslater deleted the tickets/DM-38831 branch May 1, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants