-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DM-39343] Breaking down all tap schema databases #120
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SSOs are fine, but I don't really see a need to have five separate ones, as there is only one back-end DB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that they can have different schemas as we test things and move it around, it doesn't hurt us and it follows the pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which one is the backend DB? i thought we had a bunch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know there is currently only one DP0.3 / SSO database - a Postgres DB at SLAC.
It's not wrong to have five identical TAP_SCHEMA builds for this, and I can think of some ways we might use them, conceivably, so I'm not asking you to remove them, but just noting that it's flexibility we might not need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And how many environments do you want connected to that SSO database? just usdf-dev? usdf-dev and usdf-prod? I want to know not only which databases exist but which tap services exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on @fritzm's response on #dm-rsp-team this morning, I think the answer is that we want an SSO-only TAP service on all five of idf-prod, idf-int, idf-dev, usdf-prod, and usdf-dev. All of them will normally point to the same SSO-only Postgres database at USDF, except that during the upcoming USDF outage the IDF RSPs' SSO TAP services will point to the replica of that database recently set up by Dan in the Google cloud. (See Slack for more discussion of the timing of the switchover.)
As I said above, I don't foresee any reason for the TAP_SCHEMA content of the five to be different from each other, but if you want to create five images as a hedge, I don't object.