DM-31420: Fix unit errors in APDB schema #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-31420
branch
from
00a9c2b
to
da6117b
Compare
ngmy->nJy asec->arcsec days->day degrees->degree (mas/yr)^2->mas^2/yr^2 date->day MJD->day Added note about units of firstObservationDate stat.error:->stat.error;
parejkoj
force-pushed
the
tickets/DM-31420
branch
from
da6117b
to
9ee6463
Compare
kfindeisen
approved these changes
Jul 7, 2023
| @@ -2177,88 +2178,88 @@ tables: | |||
| datatype: float | |||
| description: Estimated sky background at the position (centroid) of the object. | |||
| mysql:datatype: FLOAT | |||
| fits:tunit: nJy/asec^2 | |||
| fits:tunit: nJy/arcsec^2 | |||
There was a problem hiding this comment.
The same error shows up in yml/imsim.yaml, yml/dp01_dc2.yaml, yml/dp02_dc2.yaml. Even if you can't test them, why not do the search-and-replace?
There was a problem hiding this comment.
I've fixed imsim.yaml, but I don't want to modify the dp01/dp02 files, because they're associated with already-released data products and I believe are under a more strict modification process. I'll leave it to @gpdf to sort out those two on the other tickets about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.