Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-37911: implement dipoleNdata #132

Merged
merged 1 commit into from Sep 11, 2023
Merged

DM-37911: implement dipoleNdata #132

merged 1 commit into from Sep 11, 2023

Conversation

bsmartradio
Copy link
Contributor

Implement dipoleNdata column in the apdb

@bsmartradio bsmartradio force-pushed the tickets/DM-37911 branch 2 times, most recently from efd8333 to 1aa0048 Compare August 18, 2023 21:48
@bsmartradio
Copy link
Contributor Author

I am not sure what is failing with the yaml validator, but Jenkins did run successfully with this branch.

mrawls
mrawls reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're pretty sure the linting error is OK to ignore (and I tend to believe Lauren as a rule!), and you have a confident answer for my question about "value", this looks good to go.

yml/apdb.yaml Outdated Show resolved Hide resolved
@bsmartradio bsmartradio merged commit 0d3fc26 into main Sep 11, 2023
4 of 5 checks passed
@bsmartradio bsmartradio deleted the tickets/DM-37911 branch September 11, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrawls mrawls mrawls left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bsmartradio @mrawls