DM-41219: Fix errors in dp02 and dp02 schemas #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyMcCormick
force-pushed
the
tickets/DM-41219
branch
from
9cf4189
to
0b57e27
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-41219
branch
from
0b57e27
to
bbcda74
Compare
gpdf
requested changes
Oct 25, 2023
yml/dp02_dc2.yaml
Outdated
| @@ -8092,37 +8092,37 @@ tables: | |||
| datatype: double | |||
| mysql:datatype: DOUBLE | |||
| description: Elliptical Gaussian adaptive moments | |||
| fits:tunit: asec^2 | |||
| fits:tunit: arcsec2 | |||
There was a problem hiding this comment.
VOUnit requires arcsec**2 here.
There was a problem hiding this comment.
This should be fixed now.
gpdf
reviewed
Oct 25, 2023
yml/dp02_dc2.yaml
Outdated
| - name: ixyPSF | ||
| "@id": "#DiaSource.ixyPSF" | ||
| datatype: double | ||
| mysql:datatype: DOUBLE | ||
| description: Adaptive moments of the PSF model at the object position | ||
| fits:tunit: asec^2 | ||
| fits:tunit: arcsec2 |
JeremyMcCormick
force-pushed
the
tickets/DM-41219
branch
2 times, most recently
from
ce79156
to
b83663c
Compare
The 'stat.error' word needs to be primary and not secondary according to UCD1+ syntax.
This conforms to the astropy v5.3.3 syntax for unit specification.
This follows the standard in the VOAUnits recommendation.
JeremyMcCormick
force-pushed
the
tickets/DM-41219
branch
from
b83663c
to
3431dee
Compare
gpdf
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.