Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-41251: Add foreign key constraint from ForcedSource to Object #149

Merged
merged 2 commits into from Oct 23, 2023
Merged

DM-41251: Add foreign key constraint from ForcedSource to Object #149

merged 2 commits into from Oct 23, 2023

Conversation

JeremyMcCormick
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick commented Oct 20, 2023 •
edited

This demonstrates working foreign key constraints in felis that are loaded into the TAP_SCHEMA table.

I checked that the felis load-tap command results in the correct data for the constraint being loaded into the TAP_SCHEMA database in MySQL.

gpdf
gpdf approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a direct change to a few things:

  • Correct an error in the actual linkage
  • Shorten the visible name
  • Make the internal ID more explicit
  • Change the description

Let's get this deployed and tested and then we can add more.

JeremyMcCormick and others added 2 commits October 23, 2023 13:51
@JeremyMcCormick @gpdf
Add FK constraint from ForcedSource to Object in dp02_dc2 schema
a773134 
This demonstrates working foreign key constraints in felis that are
loaded into the TAP_SCHEMA table.
@gpdf
Correct error in Obj_FS constraint and rename
a6db091
@JeremyMcCormick JeremyMcCormick merged commit 7396851 into main Oct 23, 2023
4 checks passed
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-41251 branch October 23, 2023 20:56
@gpdf gpdf restored the tickets/DM-41251 branch October 23, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpdf gpdf gpdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JeremyMcCormick @gpdf