Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-41251: Add initial foreign-key test to DP0.3 #159

Merged
merged 1 commit into from Oct 25, 2023
Merged

DM-41251: Add initial foreign-key test to DP0.3 #159

merged 1 commit into from Oct 25, 2023

Conversation

gpdf
Copy link
Collaborator

@gpdf gpdf commented Oct 24, 2023

No description provided.

JeremyMcCormick
JeremyMcCormick approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loaded the schema into a local TAP_SCHEMA database and looked at the records in keys and key_columns, which match the new constraints in the YAML. I also don't see any errors in the schema from felis basic-check.

@gpdf gpdf merged commit 301fd19 into main Oct 25, 2023
4 checks passed
@gpdf gpdf deleted the tickets/DM-41251 branch October 25, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyMcCormick JeremyMcCormick JeremyMcCormick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gpdf @JeremyMcCormick