DM-24283: Update nullable fields

[bsmartradio]

Change several fields from non-nullable to nullable

[JeremyMcCormick]

Please delete the .idea files that were added (presumably accidentally). They don't look like they belong in the repo.

The branch also needs an "Update with rebase," too.

[JeremyMcCormick]

The commit history was fixed to take out the erroneous files and rebase was performed. Looks okay now.

[gpdf]

I'm sorry for perhaps being fussy, but I'm concerned that the commit message buries the lede, as it were. An at least equally important part of this PR is changing "Sigma" to "Err" in a number of places. Because it's not mentioned in the commit message it leaves some question as to whether it's intentional (or, say, an inadvertent regression).

Is this a remnant of work triggered by RFC-333?

The ticket reference in the PR title, to DM-23283, appears to be to something unrelated, a change to the handling of airmass. The branch name, including DM-24283, is about Avro schema documentation. Neither Jira ticket mentions the Sigma/Err change.

Could you update the commit message to clarify this, please?

There are also attribute names like DiaObject.u_scienceFluxSigma still in apdb.yaml. Should those be changed as well?

Finally, I note that identically named DiaObject fields in imsim.yaml are still in the "FluxSigma" form. Might it be preferable to change them at the same time?

Thank you!
-Gregory

[ebellm]

@bsmartradio Can you comment on why Sigma changed to Err here? This change happened in the force push after my review, it looks like. Reading https://jira.lsstcorp.org/browse/RFC-333 I believe that that the original Sigma is correct, as we're characterizing the width of the distribution of DIASource fluxes associated with the DIAObject.

[ebellm]

@gpdf I updated the PR title to match the ticket number. This change came up in the process of updating our Avro tools to build schemas directly from the sdm_schemas yaml source of truth. We identified a few fields that were not allowed to be null that needed to be; that should be the only change happening on this ticket.

[gpdf]

This seems to be appropriately limited to the stated goals now.

Please be aware that there is at least one other approved pending pull request likely to be merged today, so please check that main hasn't changed, and then rebase accordingly if needed, before merging.

[gpdf]

I'd encourage rebasing and merging this soon, as it seems it's fully signed-off - we're trying to clear a backlog of PRs on this repo.

[bsmartradio]

I'd encourage rebasing and merging this soon, as it seems it's fully signed-off - we're trying to clear a backlog of PRs on this repo.

There is one lingering issue that only shows up in ap_verify which I am trying to track down. I think I will have it sorted today.

[gpdf]

OK, no worries. If it's still in-work that's fine!

[JeremyMcCormick]

I've marked this as a draft so it doesn't get unintentionally merged as it has been approved already, but there was an indication by @bsmartradio that work still needs to be done on it.