DM-42003: Fix UCD errors in SDM schemas #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpdf
requested changes
Dec 5, 2023
JeremyMcCormick
force-pushed
the
tickets/DM-42003
branch
2 times, most recently
from
73bd9be
to
7468a27
Compare
This corrects the misspelling of 'ime:duration' to 'time:duration'.
This corrects the syntax of UCDs that included invalid words according to the UCD1+ controlled vocabulary. The corrections were straighforward aside from changing 'pos.eq.ra_dec_Cov' to 'stat.covariance;pos.eq.ra;pos.eq.dec'. This correction indicates that the column represents the complex covariance between the two positional measurements, which are listed explicitly with two different words.
JeremyMcCormick
force-pushed
the
tickets/DM-42003
branch
from
7468a27
to
5dcb3bd
Compare
I requested a re-review. I believe we decided to go with my initial change of listing both positional measurements separately rather than just using 'pos.eq'. |
gpdf
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a single typo in obsloctap and three UCDs not following standard syntax in imsim.
The imsim fixes were:
These were checked for correctness with the
ucd.parse_ucdfunction in astropy via Pydantic command line validation.