DM-42404: Run Felis validation on schemas #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow validates all of the schemas in the ./yml directory using the "felis validate" command. For now, Felis is installed using a github URL. This can be changed to "pip install felis" once the package is available on PyPI.
Install Felis rather than using a separate requirements.txt file, as this may contain conflicting depedency versions.
JeremyMcCormick
force-pushed
the
tickets/DM-42404
branch
from
15c3c02
to
11d4fe7
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-42404
branch
from
11d4fe7
to
5eb6f21
Compare
Run the validation on all updates to the repository, which will also automatically run as a PR check.
This should be helpful for developers as they incrementally commit changes on branches. It will also run automatically as a check on PRs.
JeremyMcCormick
force-pushed
the
tickets/DM-42404
branch
from
df75ab3
to
ec7d68f
Compare
cbanek
approved these changes
Jan 12, 2024
I deleted this and made note of a few warnings which are not replicated by the Pydantic model. |
This workflow is superseded by validation using the Pydantic data model. There were a few warnings from checks not implemented with the new validation, and these have been noted in Jira: https://jira.lsstcorp.org/browse/DM-42482 These can be added to the new validation framework if necessary.
This was only called from a single Github workflow and should be unnecessary now that validation has been implemented in Pydantic.
JeremyMcCormick
force-pushed
the
tickets/DM-42404
branch
from
8babc1c
to
de036df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs the new
felis validatecommand on all SDM schemas in the./ymldir. Thefelislint.yamlworkflow was removed and replaced byvalidate.yaml. Other workflows were also updated to be compatible with the current version of Felis.For now, Felis is installed via a github URL, as we are trying to reclaim the name from a dead package on PyPI. This can be changed to
pip install feliswhen that is working properly.