DM-42540: Deduplicate IDs to fix errors when loading schemas into TAP #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpdf
requested changes
Jan 18, 2024
JeremyMcCormick
changed the title
It does. There was some buggy code in felis that I fixed which was causing some of the duplicate IDs not to print. I fixed it, and I will update all of these fields. |
JeremyMcCormick
force-pushed
the
tickets/DM-42542
branch
from
acb8d6b
to
fa680cc
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-42542
branch
from
fa680cc
to
6f15224
Compare
gpdf
reviewed
Jan 23, 2024
gpdf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: this PR was originally named after DM-42542 (about multiple Felis files using the schema name "ivoa") but was in fact driven by the Jira issue DM-42540 (about actually erroneous, duplicate Felis "@id" values in some of our Felis files).
I've updated the title of this PR to be about the correct ticket, but the branch name used cannot now be changed.