DM-42781: Put the different time spans of the DP0.3 schema descriptions up front #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpdf
force-pushed
the
tickets/DM-42781
branch
from
c5ac941
to
94f3af7
Compare
gpdf
changed the title
JeremyMcCormick
requested changes
Feb 5, 2024
yml/dp03_10yr.yaml
Outdated
| @@ -2,9 +2,9 @@ | |||
| name: dp03_catalogs_10yr | |||
| "@id": "#dp03_catalogs_10yr" | |||
| description: > | |||
| Data Preview 0.3 contains the catalog products of a Solar System Science | |||
| Data Preview 0.3 (ten-year version) Contains the catalog products of a Solar System Science | |||
There was a problem hiding this comment.
Minor change: Decapitalize "Contains"
There was a problem hiding this comment.
I struggled with that a bit. How would you feel about one of these alternatives:
- The Data Preview 0.3 ten-year version contains the catalog products ...
- Data Preview 0.3 (ten-year version): Contains the catalog products ...
There was a problem hiding this comment.
I struggled with that a bit. How would you feel about one of these alternatives:
- The Data Preview 0.3 ten-year version contains the catalog products ...
- Data Preview 0.3 (ten-year version): Contains the catalog products ...
The first one seems the most straightforward to me.
There was a problem hiding this comment.
I've opted for the version with the colons, after also considering parallelism with DP0.2.
yml/dp03_1yr.yaml
Outdated
| Data Preview 0.3 contains the catalog products of a Solar System Science | ||
| Collaboration simulation of the results of SSO analysis of the wide-fast-deep data. | ||
| This set of tables is from analyzing only the first year of LSST observations. | ||
| Data Preview 0.3 (one-year version) Contains the catalog products of a Solar System Science |
There was a problem hiding this comment.
Also decapitalize "Contains" here.
gpdf
force-pushed
the
tickets/DM-42781
branch
from
94f3af7
to
29b65e0
Compare
gpdf
force-pushed
the
tickets/DM-42781
branch
from
29b65e0
to
282cad5
Compare
JeremyMcCormick
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
@gpdf will decide on the particular language for the description, so I'll approve as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was made on a branch in August 2023 and lost in the shuffle.