Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43011: Set TAP table indices and supply missing column descriptions for DP0.3 schemas #187

Merged
merged 6 commits into from Feb 26, 2024
Merged

DM-43011: Set TAP table indices and supply missing column descriptions for DP0.3 schemas #187

merged 6 commits into from Feb 26, 2024

Conversation

JeremyMcCormick
Copy link
Collaborator

Missing TAP table indices were added and some missing column descriptions were filled in.

It should be discussed further which columns should be flagged as TAP principal. I did not add these for now.

@JeremyMcCormick JeremyMcCormick marked this pull request as draft February 26, 2024 17:27
@gpdf
Copy link
Collaborator

gpdf commented Feb 26, 2024

It should be discussed further which columns should be flagged as TAP principal. I did not add these for now.

That should be a separate ticket (essentially, this ticket is a bug fix, the other ticket(s) are unfinished curation work). See also DM-42083.

gpdf
gpdf requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to go except for the table_index changes.

yml/dp03_10yr.yaml Show resolved Hide resolved
yml/dp03_10yr.yaml Outdated Show resolved Hide resolved
yml/dp03_1yr.yaml Outdated Show resolved Hide resolved
@JeremyMcCormick
Add TAP table indices to dp03_1yr
d8589d1
@JeremyMcCormick
Add missing descriptions for measurement fields in dp03_1yr schema
824607c 
The descriptions in SSSource of heliocentricX, heliocentricVX,
topocentricX, and topocentricVX were used to fill in missing
descriptions for related fields.
@JeremyMcCormick
Add missing descriptions for measurement fields in dp03_10yr schema
4b90db9 
The descriptions in SSSource of heliocentricX, heliocentricVX,
topocentricX, and topocentricVX were used to fill in missing
descriptions for related fields.
@JeremyMcCormick JeremyMcCormick marked this pull request as ready for review February 26, 2024 19:40
gpdf
gpdf requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more thing: @MelissaGraham posted some edited description in the Slack thread. Can you carry those through to here? "MPC or simulation designation..." and (e.g.) "true (noiseless) right ascension"? See current version of https://lsstc.slack.com/archives/C047DJEDUUD/p1708973596796829

@JeremyMcCormick
Copy link
Collaborator Author

Sorry, one more thing: @MelissaGraham posted some edited description in the Slack thread. Can you carry those through to here? "MPC or simulation designation..." and (e.g.) "true (noiseless) right ascension"? See current version of https://lsstc.slack.com/archives/C047DJEDUUD/p1708973596796829

These updates have been incorporated now.

gpdf
gpdf approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JeremyMcCormick JeremyMcCormick merged commit ed0c229 into main Feb 26, 2024
3 of 4 checks passed
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-43011 branch February 26, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpdf gpdf gpdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JeremyMcCormick @gpdf