DM-43097: Add autoincrement=false to some columns

[andy-slac]

Columns which are primary keys by default have autioncrement=auto in sqlalchemy which for single-column PK enables autoincrement. This does no big harm for APDB schema but creates unnecessary sequences in postgres. To avoid those extra sequences I mark all integer PK columns as autoincrement=false.

[gpdf]

Is this the right place for this? Perhaps we should handle this at the Felis-processing level instead, and default to false unless true is explicitly requested in the YAML? @JeremyMcCormick ?

[andy-slac]

Is this the right place for this? Perhaps we should handle this at the Felis-processing level instead, and default to false unless true is explicitly requested in the YAML? @JeremyMcCormick ?

From recent felis updates I think we converged on that felis follows sqlalchemy approach, that is autoincrement="auto" option for column constructor by default. I'm not super-happy about the need to specify autoincrement behavior in sdm_schemas. It may be better for sdm_schemas to be pure science data model, and have all backend-specific details in a separate layer (this is more or less what I did for dax_apdb, but for dax_ppdb I'm trying to use felis' native methods).

[JeremyMcCormick]

Is this the right place for this? Perhaps we should handle this at the Felis-processing level instead, and default to false unless true is explicitly requested in the YAML? @JeremyMcCormick ?

I would approve this for now given that it is only a minor change to four columns.

Revisiting and possibly changing Felis's default behavior for the autoincrement field seems like a separate issue that need not block this update. If we do change autoincrement to False by default, these settings on apdb columns would just mirror the new default value. So it would be a harmless change, anyways, and we could easily revert it later.

I can make a ticket proposing to change the default for autoincrement to False if the consensus is that this would be more reasonable that auto. I would still approve this PR though regardless of what decision we make about a new default.

[JeremyMcCormick]

This is fine for now.

We may revisit how autoincrement works in the future within Felis.