Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-31912: Add extra GAaP columns to sdm_schema #27

Merged
merged 1 commit into from Sep 30, 2021
Merged

DM-31912: Add extra GAaP columns to sdm_schema #27

merged 1 commit into from Sep 30, 2021

Conversation

arunkannawadi
Copy link
Member

@arunkannawadi arunkannawadi commented Sep 27, 2021 •
edited

PR to reflect the additional GAaP columns added to the object table.

I have not included the changes to be made in DM-31825

@arunkannawadi
Copy link
Member Author

@sr525 I have to drop the "Add underscore after filter label" commit here and should be covered in #28. This is because my commit only modifies it for GAaP columns while Yusra's PR will modify it for all columns in the Object table, which will lead to differences in non-GAaP columns.

@yalsayyad
Add additional gaap columns and rename existing
5ef8291 
to match new aperture naming convention
@yalsayyad yalsayyad force-pushed the tickets/DM-31912 branch 2 times, most recently from 5213b35 to 5ef8291 Compare September 30, 2021 01:15
@yalsayyad yalsayyad merged commit 2708107 into master Sep 30, 2021
@yalsayyad yalsayyad deleted the tickets/DM-31912 branch September 30, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sr525 sr525 Awaiting requested review from sr525

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@arunkannawadi @yalsayyad