DM-33694: Add match_ref/match_object schemas #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
approved these changes
Mar 23, 2022
yml/imsim.yaml
Outdated
| @@ -8275,3 +8275,51 @@ tables: | |||
| datatype: long | |||
| mysql:datatype: BIGINT | |||
| description: | |||
| - name: match_ref | |||
There was a problem hiding this comment.
Every other relation/table in this file is lowercaseCamel.
If you're curious what this table's friends are going to look like, go to https://data-int.lsst.cloud/portal select the collection called dp02_test_preops blah blah blah and scroll through the tables
yml/imsim.yaml
Outdated
| '@id': '#match_ref.index' | ||
| datatype: long | ||
| mysql:datatype: BIGINT | ||
| description: Incrementing (implied) index. Placeholder for reference object ID. |
There was a problem hiding this comment.
What's the "reference object ID"?
yml/imsim.yaml
Outdated
| '@id': '#match_ref.match_count' | ||
| datatype: long | ||
| mysql:datatype: BIGINT | ||
| description: True for sources that were selected for matching |
yml/imsim.yaml
Outdated
| @@ -8275,3 +8275,51 @@ tables: | |||
| datatype: long | |||
| mysql:datatype: BIGINT | |||
| description: | |||
| - name: match_ref | |||
| '@id': '#match_ref' | |||
| description: Match indices and metadata for a reference catalog matched to an object table | |||
There was a problem hiding this comment.
This description sounds kinda abstract. E.g. you reference "a reference catalog" instead of the very specific truthSummary and object tables that it contains matches for.
taranu
force-pushed
the
tickets/DM-33694
branch
3 times, most recently
from
ab85719
to
e7d5724
Compare
taranu
force-pushed
the
tickets/DM-33694
branch
from
e7d5724
to
edcc9a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.