Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish dp02Schema tap-schema to -stable,-int, and idfint #44

Merged
merged 3 commits into from Mar 17, 2022

Conversation

fritzm
Copy link
Contributor

@fritzm fritzm commented Mar 10, 2022

No description provided.

@fritzm fritzm requested a review from rra March 10, 2022 19:39
@gpdf gpdf self-requested a review March 10, 2022 21:29
Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize that this is not final. However, before its first deployment, can we at least harmonize the top level with what was done for DP0.1. The "schema" for DP0.1 was named "dp01_dc2_catalogs". Here it's just named "dp02". I think the same logic applies for including "_dc2" this time, so we should just do that. Regarding appending "_catalogs", that depends on whether the intent is to include the image metadata tables (the original "Exposure" and "Visit" tables) in the same "schema" (in the TAP sense of the word) as the catalogs.

One argument against doing so (and therefore keeping "_catalogs" for DP0.2) is that we've talked about a model (in the final system) where we host the catalog tables only on Qserv, and the image metadata tables both on Qserv and in the Consolidated Database, because the image metadata tables are useful in both contexts.

@gpdf
Copy link
Collaborator

gpdf commented Mar 10, 2022

For today's deployment I'll be happy if we just change to "dp02_dc2_catalogs", because there are no image metadata tables in this schema yet.

@fritzm
Copy link
Contributor Author

fritzm commented Mar 10, 2022

@gpdf done re. dp02_dc2 rename (though not sure why that was a particularly good name choice the first time?)

Is there also a preference/direction on top level "@id:" for dp0.2 here?

@fritzm fritzm requested a review from gpdf March 10, 2022 22:01
@gpdf
Copy link
Collaborator

gpdf commented Mar 10, 2022

It was decided in collaboration with the CET, to make it clear right up front that the delegates were working with DC2 data.

@fritzm fritzm force-pushed the tickets/DM-33909-1 branch 2 times, most recently from 7bba3d1 to b54cac1 Compare March 10, 2022 22:10
@rra rra removed their request for review March 15, 2022 20:51
@rra
Copy link
Member

rra commented Mar 15, 2022

I don't really know much about this and will leave the review to Gregory.

gpdf
gpdf previously requested changes Mar 17, 2022
yml/dp02_dc2.yaml Outdated Show resolved Hide resolved
yml/dp02_dc2.yaml Outdated Show resolved Hide resolved
@fritzm fritzm force-pushed the tickets/DM-33909-1 branch 3 times, most recently from 8ad4cb7 to 37582f4 Compare March 17, 2022 18:40
@fritzm fritzm requested a review from gpdf March 17, 2022 18:55
@fritzm fritzm dismissed gpdf’s stale review March 17, 2022 18:56

requests addressed

@fritzm fritzm merged commit 4d7e903 into main Mar 17, 2022
@fritzm fritzm deleted the tickets/DM-33909-1 branch March 17, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants