DM-34480: Add APDB schema definition based on felis #52
Conversation
yml/apdb.yaml
Outdated
| # datatype: float | ||
| # fits:tunit: arcsec | ||
| # description: Separation distance of nearbyLowzGal. | ||
| # mysql:datatype: FLOAT |
There was a problem hiding this comment.
Bunch of columns are commented out, these were added recently to baselineSchema. If they are not useful in APDB I can remove them, otherwise I can un-comment them.
There was a problem hiding this comment.
These are not implemented in AP yet but will be, so please do include them.
There was a problem hiding this comment.
I have uncommented these new columns.
Another small change since review - length attribute added to timestamp and binary columns. length is not used currently by APDB classes, it is mostly to suppress felis messages.
yml/apdb.yaml
Outdated
| # datatype: float | ||
| # fits:tunit: arcsec | ||
| # description: Separation distance of nearbyLowzGal. | ||
| # mysql:datatype: FLOAT |
There was a problem hiding this comment.
These are not implemented in AP yet but will be, so please do include them.
| - "#DiaObject.validityStart" | ||
| mysql:engine: MyISAM | ||
| mysql:charset: latin1 | ||
| - name: SSObject |
There was a problem hiding this comment.
These SSObject tables are out of date. The correct ones are at https://jira.lsstcorp.org/browse/RFC-620 (already in felis YAML!)
We might as well update baselineSchema.yaml at the same time.
There was a problem hiding this comment.
SSObject schema was replaced with the one from RFC-620, in both new apdb.yaml and baselineSchema.yaml.
This schema is the same as currently defined in existing YAML files in dax_apdb and ap_association packages. Some columns have their `nullable` attributes corrected to reflect the design. There are differences w.r.t. baselineSchema, in particular APDB schema does not include few columns that were added recently to baseline schema - `nearbyExtObj[1-3]`, `nearbyLowzGal`, and corresponding separation columns. And there are few columns in APDB that do not exist in baseline schema for DIA tables.
andy-slac
force-pushed
the
tickets/DM-34480
branch
from
7d3e70e
to
794e31b
Compare
Both `apdb.yaml` and `baselineSchema.yaml` not have SS Products tables schema as defined in RFC-620.
andy-slac
force-pushed
the
tickets/DM-34480
branch
from
794e31b
to
62435a8
Compare
@ebellm, sorry, I misunderstood that. I have force-pushed new version with all four tables from RFC-620. I ran all tests again, and restarted Jenkins. |
This schema is the same as currently defined in existing YAML files in
dax_apdb and ap_association packages. Some columns have their
nullableattributes corrected to reflect the design. There are differences w.r.t.
baselineSchema, in particular APDB schema does not include few columns
that were added recently to baseline schema -
nearbyExtObj[1-3],nearbyLowzGal, and corresponding separation columns. And there are fewcolumns in APDB that do not exist in baseline schema for DIA tables.