Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35221: Mark single-character columns as variable-length strings in VOTable output #62

Merged
merged 1 commit into from Jun 15, 2022
Merged

DM-35221: Mark single-character columns as variable-length strings in VOTable output #62

merged 1 commit into from Jun 15, 2022

Conversation

gpdf
Copy link
Collaborator

@gpdf gpdf commented Jun 14, 2022

Workaround for a Firefly bug but legitimate in its own right.

@gpdf gpdf requested a review from cbanek June 14, 2022 22:18
cbanek
cbanek approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@cbanek cbanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gpdf gpdf merged commit d9e1a4a into main Jun 15, 2022
@gpdf gpdf deleted the tickets/DM-35221 branch June 15, 2022 17:57
@gpdf
Copy link
Collaborator Author

gpdf commented Jun 15, 2022

Thanks - let's get this deployed to data-int today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbanek cbanek cbanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gpdf @cbanek