DM-35173: Add descriptions to CcdVisit and Visit Tables #65
Conversation
cmsaunders
force-pushed
the
tickets/DM-35173
branch
2 times, most recently
from
d04e603
to
9a29728
Compare
| - name: band | ||
| '@id': '#Visit.band' | ||
| datatype: char | ||
| length: 1 | ||
| description: '' | ||
| votable:arraysize: "*" |
There was a problem hiding this comment.
Portal needs to keep this votable:arraysize line in order to work around a bug.
| - name: band | ||
| '@id': '#CcdVisit.band' | ||
| datatype: char | ||
| length: 1 | ||
| description: '' | ||
| votable:arraysize: "*" |
There was a problem hiding this comment.
Same comment as above, we need this line at the moment.
yml/dp02_dc2.yaml
Outdated
| - name: expMidpt | ||
| '@id': '#Visit.expMidpt' | ||
| datatype: timestamp | ||
| length: 6 | ||
| mysql:datatype: DATETIME(6) | ||
| description: '' | ||
| description: Midpoint for exposure at the fiducial center of the focal plane array. |
There was a problem hiding this comment.
Just to make it super obvious, it's probably worth saying "Midpoint time" or otherwise making it clear that it's the time.
yml/dp02_dc2.yaml
Outdated
| - name: azimuth | ||
| '@id': '#Visit.azimuth' | ||
| datatype: double | ||
| description: '' | ||
| description: Azimuth of focal plane center. |
There was a problem hiding this comment.
Is this at the exposure midpoint?
yml/dp02_dc2.yaml
Outdated
| - name: expTime | ||
| '@id': '#Visit.expTime' | ||
| datatype: double | ||
| description: '' | ||
| description: Average duration of exposure, accurate to 10ms. |
There was a problem hiding this comment.
Not sure how to clarify this succinctly, but users might not know that this means spatially-averaged. Might be ok to leave off the average part.
There was a problem hiding this comment.
I just changed this to "Spatially-averaged duration of exposure..."
yml/dp02_dc2.yaml
Outdated
| - name: decl | ||
| '@id': '#Visit.decl' | ||
| datatype: double | ||
| description: '' | ||
| description: Decl of focal plane center |
There was a problem hiding this comment.
I think it's worth writing out declination.
yml/dp02_dc2.yaml
Outdated
| description: '' | ||
| description: Start of the exposure at the fiducial center of the focal plane array, | ||
| TAI, accurate to 10ms. | ||
| defaultValue: CURRENT_TIMESTAMP |
There was a problem hiding this comment.
This is something that was in the BaselineSchema, but I think I will take it out, because I'm not sure how it could be helpful to have a default value for obsStart. It seems more likely to cause confusion.
cmsaunders
force-pushed
the
tickets/DM-35173
branch
from
9a29728
to
6dd2b38
Compare
cmsaunders
force-pushed
the
tickets/DM-35173
branch
from
6dd2b38
to
92bc1a1
Compare
No description provided.