Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35123: TAP_SCHEMA updates for DP0.2 production data #72

Merged
merged 2 commits into from Jun 25, 2022

Conversation

ctslater
Copy link
Member

No description provided.

Copy link
Contributor

@fritzm fritzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- one question re. deletion vs commenting-out

@@ -8183,232 +8183,6 @@ tables:
mysql:datatype: FLOAT
description: 1-sigma uncertainty on y position
fits:tunit: pixel
- name: ForcedSourceOnDiaObject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you want to leave this in, but commented out (#), as was done for the match tables in this file (just to ease reference and also to make later resuscitation easier?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, and that's easier if there's anything else we need to change while it's commented-out.

@ctslater ctslater merged commit fb612a2 into main Jun 25, 2022
@ctslater ctslater deleted the tickets/DM-35123 branch June 25, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants