Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35125: fixups and column reordering #75

Merged
merged 2 commits into from Jun 27, 2022

Conversation

gpdf
Copy link
Collaborator

@gpdf gpdf commented Jun 27, 2022

Correct a Felis key from the typo "ivoa:dec" to "ivoa:ucd"; this needs CI support to catch in the future.

Apply presentation-order column ordering, via TAP_SCHEMA column_index, to the ObsCore table.

@gpdf gpdf requested a review from ctslater June 27, 2022 20:28
@gpdf gpdf marked this pull request as ready for review June 27, 2022 20:28
Copy link
Member

@ctslater ctslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gpdf
Copy link
Collaborator Author

gpdf commented Jun 27, 2022

Leaving catalog column reordering to a future PR.

@gpdf gpdf merged commit 42a7693 into main Jun 27, 2022
@gpdf gpdf deleted the tickets/DM-35125-column-reordering branch June 27, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants