Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35956: Correct error in ObsTAP metadata; supply missing metadata #87

Merged
merged 2 commits into from Aug 22, 2022
Merged

DM-35956: Correct error in ObsTAP metadata; supply missing metadata #87

merged 2 commits into from Aug 22, 2022

Conversation

gpdf
Copy link
Collaborator

@gpdf gpdf commented Aug 19, 2022

This PR corrects an error in the std designation for the lsst_patch attribute, and adds descriptions and UCDs for all the lsst_* attributes.

@gpdf gpdf requested a review from fritzm August 19, 2022 19:33
@gpdf
Copy link
Collaborator Author

gpdf commented Aug 19, 2022

@fritzm OK to merge and deploy to data-int after your review. I don't expect I'll have another update before late afternoon - 3 hours of meetings ahead now.

fritzm
fritzm approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@fritzm fritzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fritzm fritzm merged commit 64064b4 into main Aug 22, 2022
@fritzm fritzm deleted the tickets/DM-35956 branch August 22, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzm fritzm fritzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gpdf @fritzm