DM-30321: Validate the schema in ci_hsc_gen3 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
force-pushed
the
tickets/DM-30321
branch
2 times, most recently
from
37a158b
to
b2dec42
Compare
yalsayyad
approved these changes
May 28, 2021
yalsayyad
approved these changes
May 28, 2021
yml/hsc.yaml
Outdated
| description: patch ID | ||
| mysql:datatype: TEXT | ||
| mysql:datatype: BIGINT |
There was a problem hiding this comment.
PatchIds, tractIds, and detectorIds are small human manageable integers (unlike sourceIds)
4 byte int, INTEGER is prob sufficient for all 3 unless you know something I don't
There was a problem hiding this comment.
I also think INTEGER should be sufficient for all 3, but I see these columns have the type of BIGINT in the output parquet files.
Since we aren't checking the data types in CI and for now we'd just force the types before the database ingest, we may also set this to be what we want (INTEGER) rather than what the parquet files have (BIGINT). Do you have a preference?
There was a problem hiding this comment.
I'm changing those to INTEGER despite of their types in the output parquet files
hsinfang
force-pushed
the
tickets/DM-30321
branch
from
b2dec42
to
79f6e32
Compare
Keep a Gen2 copy for ci_hsc_gen2 for the time being
Currently, these columns are stored as int64 in the parquet outputs. But in sdm_schemas we use what we want them to me, and downstream codes can type cast.
hsinfang
force-pushed
the
tickets/DM-30321
branch
from
79f6e32
to
311ebcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.