DM-35299: Add truth_type columns to imsim MatchesObject/Truth #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctslater
reviewed
Nov 8, 2022
| - name: truth_type | ||
| '@id': '#MatchesTruth.truth_type' | ||
| datatype: long | ||
| mysql:datatype: BIGINT |
There was a problem hiding this comment.
Regular int seems sufficient to hold values up to 3? Any other reason to make this a long/BIGINT? Same for match_truth_type below.
There was a problem hiding this comment.
The truth_type column in the already-ingested truth_summary tables is an int64. I'm not sure if they were originally like that or if I and/or pandas did something wrong in ingest. At any rate, it needs to be this way or else ci_imsim will fail, and I don't think fixing it is worth the effort at this point. I presume the fix for testdata_ci_imsim wouldn't be difficult but for every other existing repo...?
taranu
force-pushed
the
tickets/DM-35299
branch
from
b4048b0
to
cb78f28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.