u/jbosch/DM-1188 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still not the most efficient method of shapelet evaluation (that's MatrixBuilder), but it's faster and more convenient than looping over pixels in Python.
MatrixBuilder provides the functionality previously present in MultiShapeletMatrixBuilder, ModelBuilder, and some private code in meas_multifit's psf.cc, with a unified interface, better code reuse, and a design more amenable to future micro-optimization.
This has been replaced by MatrixBuilder
Replaced by MatrixBuilder
This brings MultiShapeletFunction's nomenclature in line with that used by MultiShapeletBasis and MatrixBuilder.
Using apply() for both Factory and Builder implementations was a source of confusion, so these have been renamed to "makeBuilder" (for factories) and "buildMatrix" (for builders).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May be easiest to review commit-by-commit, as the content is well separated and the logs should describe the purpose of the change. The biggest by far is 8c99a21, which involves two new files that replace (and unify, and expand) the code in 13feffe and 6d5f02e. I've tried to include very complete API documentation and some detailed implementation notes, which I hope will help with the review.