Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-8467: Wrap lsst_distrib with pybind11 #13

Merged
merged 1 commit into from
Mar 7, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,10 @@ config.log
*.dylib
*.cfgc
*.pyc
*_wrap.cc
*Lib.py
doc/html
doc/*.tag
doc/*.inc
doc/doxygen.conf
doc/xml
tests/.tests
version.py
examples/timeModels.py
3 changes: 2 additions & 1 deletion examples/SConscript
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# -*- python -*-
from lsst.sconsUtils import scripts
scripts.BasicSConscript.examples()
scripts.BasicSConscript.pybind11(["timeModels"])
#scripts.BasicSConscript.examples()
96 changes: 96 additions & 0 deletions examples/timeModels.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
/*
* LSST Data Management System
*
* This product includes software developed by the
* LSST Project (http://www.lsst.org/).
* See the COPYRIGHT file
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the LSST License Statement and
* the GNU General Public License along with this program. If not,
* see <https://www.lsstcorp.org/LegalNotices/>.
*/
#include <pybind11/pybind11.h>
//#include <pybind11/stl.h>
#include "numpy/arrayobject.h"
#include "ndarray/pybind11.h"

#include "lsst/shapelet.h"
#include "lsst/afw/fits.h"
#include "lsst/afw/cameraGeom.h"
#include "lsst/afw/image.h"
#include "lsst/afw/table.h"
#include "lsst/afw/geom/ellipses.h"

namespace py = pybind11;
using namespace pybind11::literals;

namespace lsst {
namespace shapelet {

namespace {
template <typename T>
double buildModelsImpl(
int nPixels, int basisSize,
lsst::shapelet::MatrixBuilder<T> const & builder,
ndarray::Array<double const,2> const & parameters,
std::string const & ellipseType
) {
lsst::afw::geom::ellipses::Ellipse ellipse(
lsst::afw::geom::ellipses::BaseCore::make(ellipseType),
lsst::afw::geom::Point2D()
);
ndarray::Array<T,2,2> matrixT = ndarray::allocate(basisSize, nPixels);
ndarray::Array<T,2,-2> matrix = matrixT.transpose();
double result = 0.0;
for (ndarray::Array<double const,2>::Iterator i = parameters.begin(); i != parameters.end(); ++i) {
ellipse.setParameterVector(i->asEigen());
builder(matrix, ellipse);
result += matrix.asEigen().norm();
}
return result;
}

void buildModelsF(
int nPixels, int basisSize,
lsst::shapelet::MatrixBuilder<float> const & builder,
ndarray::Array<double const,2> const & parameters,
std::string const & ellipseType
) {
buildModelsImpl(nPixels, basisSize, builder, parameters, ellipseType);
}

void buildModelsD(
int nPixels, int basisSize,
lsst::shapelet::MatrixBuilder<double> const & builder,
ndarray::Array<double const,2> const & parameters,
std::string const & ellipseType
) {
buildModelsImpl(nPixels, basisSize, builder, parameters, ellipseType);
}
}

PYBIND11_PLUGIN(_timeModels) {
py::module mod("_timeModels", "");

if (_import_array() < 0) {
PyErr_SetString(PyExc_ImportError, "numpy.core.multiarray failed to import");
return nullptr;
}

mod.def("buildModelsF", buildModelsF);
mod.def("buildModelsD", buildModelsD);

return mod.ptr();
}

}} // lsst::shapelet
169 changes: 0 additions & 169 deletions examples/timeModels.i

This file was deleted.

70 changes: 70 additions & 0 deletions examples/timeModels.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
from __future__ import absolute_import
from __future__ import print_function

import numpy
import pickle
import os
import sys
import argparse
import time
import resource
import lsst.shapelet.tractor

from _timeModels import *

def main():
parser = argparse.ArgumentParser(description="Benchmark shapelet-based galaxy model evaluation")
parser.add_argument("-p", "--psf", help="Pickled PSF to use",
default="psf.p", type=str, metavar="FILE")
parser.add_argument("-r", "--repeat", help="Number of times to repeat the test (loop in Python)",
default=100, type=int)
parser.add_argument("-n", "--n-samples", help="Number of parameter points to evaluate (loop in C++)",
default=200, type=int)
parser.add_argument("--n-disk-terms", help="Number of Gaussians in disk (exponential) component",
default=8, type=int)
parser.add_argument("--n-bulge-terms", help="Number of Gaussians in bulge (de Vaucouleur) component",
default=8, type=int)
parser.add_argument("--n-x-pixels", help="Number of pixels in x direction (footprint is a rectangle)",
default=20, type=int)
parser.add_argument("--n-y-pixels", help="Number of pixels in y direction (footprint is a rectangle)",
default=20, type=int)
parser.add_argument("--double-precision", help="Use double precision instead of single precision",
default=False, action="store_true")
args = parser.parse_args()
bulge = lsst.shapelet.tractor.loadBasis("luv", args.n_bulge_terms)
disk = lsst.shapelet.tractor.loadBasis("lux", args.n_disk_terms)
bulge.scale(0.6)
disk.merge(bulge)
with open(os.path.join(os.path.split(__file__)[0], args.psf), "r") as psfFile:
psf = pickle.load(psfFile)
xMin = -args.n_x_pixels // 2
yMin = -args.n_y_pixels // 2
if args.double_precision:
dtype = numpy.float64
Builder = lsst.shapelet.MatrixBuilderD
func = buildModelsD
else:
dtype = numpy.float32
Builder = lsst.shapelet.MatrixBuilderF
func = buildModelsF

x, y = numpy.meshgrid(numpy.arange(xMin, xMin+args.n_x_pixels, dtype=dtype),
numpy.arange(yMin, yMin+args.n_y_pixels, dtype=dtype))
builder = Builder(x.flatten(), y.flatten(), disk, psf)
parameters = numpy.random.randn(args.n_samples, 5)
cpuTime1 = time.clock()
res1 = resource.getrusage(resource.RUSAGE_SELF)
for n in range(args.repeat):
func(x.size, disk.getSize(), builder, parameters, "SeparableConformalShearLogTraceRadius")
cpuTime2 = time.clock()
res2 = resource.getrusage(resource.RUSAGE_SELF)
factor = args.n_samples * args.repeat
print("Time per model evaluation (seconds): cpu=%g, user=%g, system=%g" % (
(cpuTime2 - cpuTime1) / factor,
(res2.ru_utime - res1.ru_utime) / factor,
(res2.ru_stime - res1.ru_stime) / factor
))

if __name__ == "__main__":
main()

12 changes: 11 additions & 1 deletion python/lsst/shapelet/SConscript
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
# -*- python -*-
from lsst.sconsUtils import scripts
scripts.BasicSConscript.python(['shapeletLib'])
scripts.BasicSConscript.pybind11(["constants",
"shapeletFunction",
"gaussHermiteProjection",
"gaussHermiteConvolution",
"multiShapeletFunction",
"multiShapeletBasis",
"matrixBuilder",
"hermiteTransformMatrix",
"radialProfile",
"functorKeys",
"basisEvaluator"])