New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-14828: Update pybind11 wrappers for 2.2 #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird formatting needs to be fixed
examples/timeModels.cc
Outdated
|
||
mod.def("buildModelsF", buildModelsF); | ||
PYBIND11_MODULE(_timeModels, mod) { | ||
mod.def("buildModelsF", buildModelsF); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indention seems off here
py::module mod("basisEvaluator"); | ||
|
||
py::class_<BasisEvaluator, std::shared_ptr<BasisEvaluator>> clsBasisEvaluator(mod, "BasisEvaluator"); | ||
py::class_<BasisEvaluator, std::shared_ptr<BasisEvaluator>> clsBasisEvaluator(mod, "BasisEvaluator"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indention seems off here
|
||
py::enum_<BasisTypeEnum>(mod, "BasisTypeEnum") | ||
PYBIND11_MODULE(constants, mod) { | ||
py::enum_<BasisTypeEnum>(mod, "BasisTypeEnum") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
python/lsst/shapelet/functorKeys.cc
Outdated
py::module mod("functorKeys"); | ||
|
||
py::class_<ShapeletFunctionKey, std::shared_ptr<ShapeletFunctionKey>> clsShapeletFunctionKey( | ||
py::class_<ShapeletFunctionKey, std::shared_ptr<ShapeletFunctionKey>> clsShapeletFunctionKey( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
|
||
py::class_<GaussHermiteConvolution, std::shared_ptr<GaussHermiteConvolution>> clsGaussHermiteConvolution( | ||
PYBIND11_MODULE(gaussHermiteConvolution, mod) { | ||
py::class_<GaussHermiteConvolution, std::shared_ptr<GaussHermiteConvolution>> clsGaussHermiteConvolution( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
py::module mod("matrixBuilder"); | ||
|
||
declareMatrixBuilderTemplates<float>(mod, "F"); | ||
declareMatrixBuilderTemplates<float>(mod, "F"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
|
||
py::class_<MultiShapeletBasisComponent, std::shared_ptr<MultiShapeletBasisComponent>> | ||
PYBIND11_MODULE(multiShapeletBasis, mod) { | ||
py::class_<MultiShapeletBasisComponent, std::shared_ptr<MultiShapeletBasisComponent>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
py::module mod("multiShapeletFunction"); | ||
|
||
py::class_<MultiShapeletFunction, std::shared_ptr<MultiShapeletFunction>> clsMultiShapeletFunction( | ||
py::class_<MultiShapeletFunction, std::shared_ptr<MultiShapeletFunction>> clsMultiShapeletFunction( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
|
||
py::class_<RadialProfile, std::shared_ptr<RadialProfile>> clsRadialProfile(mod, "RadialProfile"); | ||
PYBIND11_MODULE(radialProfile, mod) { | ||
py::class_<RadialProfile, std::shared_ptr<RadialProfile>> clsRadialProfile(mod, "RadialProfile"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
py::module mod("shapeletFunction"); | ||
|
||
py::class_<ShapeletFunction, std::shared_ptr<ShapeletFunction>> clsShapeletFunction(mod, | ||
py::class_<ShapeletFunction, std::shared_ptr<ShapeletFunction>> clsShapeletFunction(mod, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
I don't know how the weird indentation happened. Thanks for catching those. I fixed them all. |
No description provided.