Review for DM-5197: new shapelet PSF approximation code #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,6 +71,8 @@ class MultiShapeletFunction { | |||
|
|
|||
| MultiShapeletFunction() : _components() {} | |||
|
|
|||
| MultiShapeletFunction(MultiShapeletFunction const & other) = default; | |||
There was a problem hiding this comment.
Also add move and move assignment (and then also copy assignment) constructors unless there is a compelling reason not to.
A compiler-generated copy constructor was already available in C++, but this makes it available in Python as well.
TallJimbo
force-pushed
the
tickets/DM-5197
branch
from
f80a79e
to
96c92f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.