Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-14809: RingsSkyMap incorrect at south pole and RA=360 #23

Merged
merged 4 commits into from
Jun 27, 2018
Merged

DM-14809: RingsSkyMap incorrect at south pole and RA=360 #23

merged 4 commits into from
Jun 27, 2018

Commits on Jun 26, 2018

  1. RingsSkyMap: fix bugs in tract numbering 

    getRingIndices, findTract and findTractAll had off-by-one bugs.
These affect the setting of primary flags (e.g. detect_isPrimary) in
pipe_tasks for tracts near the RA=360 line. However, this involves
renumbering some of the tracts (specifically, those on the RA=360 line).

We use the existing version mechanism to support the old tract numbering.
version=0 is valid up until DM-14809, version=1 is valid afterwards.
The version is preserved in the skymap pickle, so this Just Works.
For version=0, we leave the tract numbering as it is (broken in two places:
there is one duplicated tract (the first tract on the first ring) and
one missing tract (the first tract on the last ring)), but fix the lookup
in the findTract method to work with the broken numbering.

Included in these changes is a fix for non-zero raStart: simply using fmod
doesn't work to wrap angles because it leaves negative values as negative.
Using Angle.wrap works.

Added specific tests for RingsSkyMap and generic tests for all skymaps
to catch these sorts of bugs.

Thanks to Sogo Mineo (NAOJ) for finding and diagnosing these bugs!
    @PaulPrice
    PaulPrice committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    8fc42f1 View commit details
    Browse the repository at this point in the history

  2. git: ignore coverage cache file

    @PaulPrice
    PaulPrice committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    f77da49 View commit details
    Browse the repository at this point in the history

  3. plotSkyMap: update for modern matplotlib, py3 

    matplotlib's axes.color_cycle parameter is deprecated/gone, so use
different method of cycling colors. Plot tract number instead of dot.
    @PaulPrice
    PaulPrice committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    813c631 View commit details
    Browse the repository at this point in the history

  4. RingsSkyMap: clarify some docs and comments 

    Requested during review.
    @PaulPrice
    PaulPrice committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    9a352e9 View commit details
    Browse the repository at this point in the history