Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/DM-16801 #30

Merged
merged 2 commits into from Dec 15, 2018
Merged

tickets/DM-16801 #30

merged 2 commits into from Dec 15, 2018

Conversation

natelust
Copy link
Contributor

Support getting patch info from sequential index

Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small doc suggestion.

If it's not too hard, adding a new test function to at least one of the existing tests to check that getPatchIndexPair and getSequentialPatchIndex are each other's inverses would be good.

@@ -241,11 +249,15 @@ def getPatchInfo(self, index):
"""Return information for the specified patch

@param[in] index: index of patch, as a pair of ints;
negative values are not supported
negative values are not supported, may be a single
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest rewriting to:

index of patch, as a pair of ints or a single sequential index as returned by getSequentialPatchIndex. Negative numbers are not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants