Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-19887: Use geom rather than afwGeom #37

Merged
merged 2 commits into from May 24, 2019
Merged

DM-19887: Use geom rather than afwGeom #37

merged 2 commits into from May 24, 2019

Conversation

timj
Copy link
Member

@timj timj commented May 24, 2019

No description provided.

@timj timj requested a review from TallJimbo May 24, 2019 21:32
TallJimbo
TallJimbo approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

As an aside (not a recommendation for this ticket!), this kind of refactoring is a big reason why my preferred form of import for new code is now from <module> import <symbols>.

@timj timj merged commit 9d8f394 into master May 24, 2019
@timj timj deleted the tickets/DM-19887 branch May 24, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @TallJimbo