Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace afwGeom with geom #39

Merged
merged 1 commit into from Jul 24, 2019
Merged

Replace afwGeom with geom #39

merged 1 commit into from Jul 24, 2019

Conversation

timj
Copy link
Member

@timj timj commented Jul 23, 2019

No description provided.

@timj timj requested a review from SimonKrughoff July 23, 2019 20:52
SimonKrughoff
SimonKrughoff suggested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@SimonKrughoff SimonKrughoff left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following files mention afwGeom:

python/lsst/skymap/detail/wcsFactory.py
examples/showVisitSkyMap.py

SimonKrughoff
SimonKrughoff approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@SimonKrughoff SimonKrughoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I saw mentions of afwGeom and thought that was a mistake, but I see those are used for functions not reimplemented in geom.

@timj timj merged commit 380d4d4 into master Jul 24, 2019
@timj timj deleted the tickets/DM-20566-skymap branch July 24, 2019 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonKrughoff SimonKrughoff SimonKrughoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @SimonKrughoff