DM-27147: Move writing the skyMap dataset next to registering it. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonKrughoff
approved these changes
Nov 24, 2020
python/lsst/skymap/baseSkyMap.py
Outdated
| """Add skymap, tract, and patch Dimension entries to the given Gen3 | ||
| Butler Registry. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| name : `str` | ||
| The name of the skymap. | ||
| registry : `lsst.daf.butler.Registry` | ||
| The registry to add to. | ||
| registry : `lsst.daf.butler.Butler` |
There was a problem hiding this comment.
registry : --> butler :
TallJimbo
force-pushed
the
tickets/DM-27147
branch
from
fefdcf8
to
c888bad
Compare
Adding a SkyMap to a Gen3 repo now all happens in one place, and we just write one "skyMap" dataset instead of the various "deep", "bestSeeing" variants - we don't need those in Gen3, because the skymap data ID already distinguishes between them.
TallJimbo
force-pushed
the
tickets/DM-27147
branch
from
c888bad
to
7688729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a SkyMap to a Gen3 repo now all happens in one place, and we just write one "skyMap" dataset instead of the various "deep", "bestSeeing" variants - we don't need those in Gen3, because the skymap data ID already distinguishes between them.