RingsSkyMap: catch exceptions from wcs #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcs.skyToPixel can throw an exception if the coordinate is very far off the image. That just means it isn't the image we're looking for. Thanks to Johnny Greco for reporting this bug.
TractInfo.findPatch was subject to the problem that if the coordinate is a long way off the tract, the wcs conversions will fail.
This makes it consistent with the same pattern elsewhere, and safer to use because it's more explicit.
r-owen
commented
Sep 29, 2016
| pixelInd = afwGeom.Point2I(self.getWcs().skyToPixel(coord.toIcrs())) | ||
| try: | ||
| pixel = self.getWcs().skyToPixel(coord.toIcrs()) | ||
| except (lsst.pex.exceptions.DomainError, lsst.pex.exceptions.RuntimeError): |
There was a problem hiding this comment.
If you want to safely reject coord that are not instances of Coord it might be safer to do this:
icrsCoord = coord.toIcrs()
try:
pixel = self.getWcs().skyToPixel(icrsCoord)
...
We want to allow any ICRS conversions to bubble up, so they shouldn't be in the try/except block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wcs.skyToPixel can throw an exception if the coordinate is very
far off the image. That just means it isn't the image we're looking
for.
Thanks to Johnny Greco for reporting this bug.