DM-32330: Register DECam narrow-band filters in skymap #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
force-pushed
the
tickets/DM-32330
branch
from
d40d627
to
e499e7e
Compare
TallJimbo
approved these changes
Oct 26, 2021
| @@ -41,6 +41,7 @@ class SkyMapDimensionPacker(DimensionPacker): | |||
| [None] | |||
| + list("ugrizyUBGVRIZYJHK") # split string into single chars | |||
| + [f"N{d}" for d in (387, 515, 656, 816, 921, 1010)] # HSC narrow-bands | |||
| + [f"N{d}" for d in (419, 540, 708, 964)] # DECam narrow-bands | |||
There was a problem hiding this comment.
My only concern is that this may change some per-band coadd object IDs and/or RNG seeds, because it changes the maximum number of bits the data ID portion can occupy. I don't think that can be avoided, but I hope that doesn't cause trouble for @laurenam in the form of making Gen2 and Gen3 different. I think on a recent ticket I helped her make the Gen2 code use this logic, so if that recollection is correct, we should be safe.
There was a problem hiding this comment.
Thanks for the heads-up. I am indeed making use of the code you gave me to use the Gen3 logic in Gen2, so hopefully all is good. I’ll keep my eye out…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.