DM-34497: Reduce memory usage of "butler register-skymap" #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registering the HSC rings skymap is triggering the OOM-killer on my Docker with 8 GB memory. The main problem is constructing the records before they are needed, so all records are in memory at once. Instead, create the records in a loop within the transaction context. This greatly reduces the memory footprint because we don't need all records in memory at once. This comes at the price of repeated calls to registry.insertDimensionData, but even if there is a small loss of performance, this is a command that gets run only once at the setting up of a Gen3 datastore, so it shouldn't be too burdensome.
TallJimbo
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Looks good! I'd probably have tried to gather up the tract insertions a bit, but thinking about it more the important thing is just doing the patch insertions in batch, and given that there are of order 100 times as many patches, I think this is good enough.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.