DM-39605: Use butler.dimensions rather than butler.registry.dimensions #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Jun 13, 2023
python/lsst/skymap/patchInfo.py
Outdated
| @@ -50,7 +50,8 @@ class PatchInfo: | |||
| Patch sequential index | |||
| tractWcs : `lsst.afw.geom.SkyWcs` | |||
| Tract WCS object. | |||
| cellInnerDimensions : `Iterable` [`int`, `int`] or `lsst.geom.Extent2I`, optional | |||
| cellInnerDimensions : `Iterable` [`int`, `int`] or `lsst.geom.Extent2I`, \ | |||
There was a problem hiding this comment.
Suggested change
| cellInnerDimensions : `Iterable` [`int`, `int`] or `lsst.geom.Extent2I`, \ | |
| cellInnerDimensions : `~collections.abc.Iterable` [`int`] or `lsst.geom.Extent2I`, \ |
There was a problem hiding this comment.
Thanks. Not sure how I missed that one, and again I think they might be trying to tell us that it's an iterable of list. Tuple[int, int] might be clearer.
python/lsst/skymap/tractBuilder.py
Outdated
| @@ -102,7 +102,8 @@ def getPatchInfo(self, index, tractWcs): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| index : `lsst.skymap.Index2D` or `Iterable` [`int`, `int`] | |||
| index : `lsst.skymap.Index2D` or `~collections.abc.Iterable` \ | |||
| [`int`, `int`] | |||
There was a problem hiding this comment.
I guess this means "iterable returning two integers", but Iterable[int, int] is probably an incorrect syntax for mypy?
There was a problem hiding this comment.
Yes. I think it might actually mean iterable of two integers because Index2D is a single x,y coordinate. I did ponder it for a few seconds and since I was unsure I left it as it was before.
Without this sphinx complains about clashing symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix some docstring errors and get
package-docsworking.