Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40057: shorten deprecation timeline and add ticket TODOs #65

Merged
merged 2 commits into from
Jul 23, 2023
Merged

DM-40057: shorten deprecation timeline and add ticket TODOs #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c526955
Shorten deprecation timeline per RFC-945.
TallJimbo Jul 18, 2023
427cca8
Add more ticket TODOs for deprecations.
TallJimbo Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions python/lsst/skymap/packers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,10 @@ def run(self, ..., data_id: DataCoordinate):

ConfigClass = SkyMapDimensionPackerConfig

# TODO: remove on DM-38687.
@classmethod
@deprecated(
reason="This classmethod cannot reflect all __init__ args and will be removed after v27.",
reason="This classmethod cannot reflect all __init__ args and will be removed after v26.",
version="v26.0",
category=FutureWarning,
)
Expand All @@ -149,19 +150,21 @@ def getIntFromFilter(cls, name):
except ValueError:
raise NotImplementedError(f"band '{name}' not supported by this ID packer.")

# TODO: remove on DM-38687.
@classmethod
@deprecated(
reason="This classmethod cannot reflect all __init__ args and will be removed after v27.",
reason="This classmethod cannot reflect all __init__ args and will be removed after v26.",
version="v26.0",
category=FutureWarning,
)
def getFilterNameFromInt(cls, num):
"""Return an band name from its integer representation."""
return cls.SUPPORTED_FILTERS[num]

# TODO: remove on DM-38687.
@classmethod
@deprecated(
reason="This classmethod cannot reflect all __init__ args and will be removed after v27.",
reason="This classmethod cannot reflect all __init__ args and will be removed after v26.",
version="v26.0",
category=FutureWarning,
)
Expand Down