DM-10686: RingsSkyMap: fix findAllTracts for poles #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djreiss
commented
Jun 1, 2017
tests/testRingsSkyMap.py
Outdated
| """ | ||
| skymap = self.getSkyMap() | ||
| deg = lsst.afw.geom.degrees | ||
| tracts = skymap.findAllTracts(lsst.afw.coord.IcrsCoord(321*deg, 90*deg)) |
There was a problem hiding this comment.
Since this is an important edge case, it might be good to do the tests on multiple different RAs.
The initial pole check was wrong (doesn't allow other tracts to be included) and unnecessary because the poles get picked up by the check at the end. Added a test. Thought about allowing negative indexing into SkyMap, but decided that would be a mistake because the SkyMap isn't really like a list, but more like a dict.
PaulPrice
force-pushed
the
tickets/DM-10686
branch
from
494c38b
to
3860438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial pole check was wrong (doesn't allow other tracts to be
included) and unnecessary because the poles get picked up by the
check at the end.
Added a test.
Thought about allowing negative indexing into SkyMap, but decided
that would be a mistake because the SkyMap isn't really like a list,
but more like a dict.