DM-41978: Switch logic used to exclude tasks #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
commented
Dec 18, 2023
| not_excluded_tasks.add(task_label) | ||
| if len(not_excluded_tasks) > 0: | ||
| grammar = "Task" if len(not_excluded_tasks) == 1 else "Tasks" | ||
| all_tasks = {taskDef.label for taskDef in pipeline.toExpandedPipeline()} |
There was a problem hiding this comment.
Does this need to be toExpandedPipeline? (A question for @natelust)
There was a problem hiding this comment.
For context: here we're just looping over all tasks in the pipeline to get a set of task names. No actual task/config manipulation is performed in this block.
There was a problem hiding this comment.
It's never quite clear for me when I need to expand my pipeline, and when I can get away with using the base pipeline object. I.e., I want to be sure that I'm including all the tasks from imported pipeline YAMLs as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.