Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42324: Register bands (via an instrument) before using them in tests. #28

Merged
merged 1 commit into from Jan 8, 2024

Conversation

TallJimbo
Copy link
Member

Test was depending on the existence of the bug described in DM-40818, which is being mostly fixed on this ticket.

Test was depending on the existence of the bug described in DM-40818,
which is being *mostly* fixed on this ticket.
Copy link

@dhirving dhirving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me -- not sure if you want Lee to sign off though, since it's his repo.

@TallJimbo TallJimbo merged commit b5039a9 into main Jan 8, 2024
7 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-42324 branch January 8, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants