Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41308: Create task to combine injection catalogs for matching #30

Merged
merged 2 commits into from Feb 26, 2024

Conversation

jtmccann
Copy link
Contributor

No description provided.

@jtmccann jtmccann force-pushed the tickets/DM-41308 branch 7 times, most recently from 1e948bf to b690759 Compare January 18, 2024 22:59
@jtmccann jtmccann force-pushed the tickets/DM-41308 branch 3 times, most recently from 0b59bbb to 6d361f5 Compare January 29, 2024 18:09
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
----------
catalog: `astropy.table.Table`
A catalog of sources.
Writes is-patch-inner, is-tract-inner, and is-primary flags.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be - or _?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got these doc strings straight from the code in meas_algorithms, so I'd assume it probably doesn't matter

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I read it, "is-patch-inner" is meant to be descriptive, rather than referencing anything specific in the code. I.e., "This thing writes an 'is-patch-inner' flag". Is that accurate?

@jtmccann jtmccann merged commit a9cb4f5 into main Feb 26, 2024
7 checks passed
@jtmccann jtmccann deleted the tickets/DM-41308 branch February 26, 2024 20:43
jtmccann added a commit that referenced this pull request Mar 21, 2024
DM-41308: Create task to combine injection catalogs for matching
jtmccann added a commit that referenced this pull request Mar 21, 2024
DM-41308: Create task to combine injection catalogs for matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants