Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-15187: Modernize sphgeom pickle support for pybind11 2. #17

Merged
merged 2 commits into from
Jul 24, 2018
Merged

DM-15187: Modernize sphgeom pickle support for pybind11 2. #17

merged 2 commits into from
Jul 24, 2018

Commits on Jul 23, 2018

  1. Add encode to python/utils.h

    @r-owen
    r-owen committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    57d82c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2018

  1. Modernize pickle support in pybind11 wrappers 

    Use pybind11::pickle instead of defining `__getstate__`
and `__setstate__` directly, as recommended for pybind11 2.2.
This eliminates compiler warnings.
    @r-owen
    r-owen committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    c9eba5f View commit details
    Browse the repository at this point in the history