DM-25867: Make package pip installable #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-25867
branch
3 times, most recently
from
30d6426
to
914932d
Compare
TallJimbo
approved these changes
Jul 9, 2020
| @@ -0,0 +1,6 @@ | |||
| pybind11 >=2.5.0 | |||
There was a problem hiding this comment.
So this directly blocks us from being able to use the pip/conda version to build the rest of the pipelines, right? It's a newer pybind11 than ndarray supports, and maybe some of our other code.
There was a problem hiding this comment.
On the plus side this package must be compatible with the new pybind11. This was an arbitrary cut and paste from the pybind11 documentation. Since it worked with 2.5 and we know it builds with the stack version it's not a problem to change it.
The implementation is very inefficient.
|
Good news. With #26 implemented the build and test now only takes 3.5 minutes instead of 15 minutes. @smonkewitz thanks for having done all the work already! |
The act of importing this seems to automatically enable parallel builds.
There is no reason to fail catastrophically if yaml is missing since the yaml feature we use is to ensure that when yaml is used we serialize properly for yaml. In the absence of pyyaml we aren't serializing to yaml. We still retain it in the requirements.txt
This makes it easier to see what is going on in the output logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.