DM-35347: Switch to pyproject.toml #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwittgen
force-pushed
the
tickets/DM-35347
branch
from
c3a02da
to
d5a4b04
Compare
timj
approved these changes
Jul 14, 2022
| requires = [ | ||
| "setuptools >= 46.6.0", | ||
| "setuptools", | ||
| "lsst-versions >= 1.3.0", | ||
| "wheel", | ||
| "pybind11 >= 2.5.0", | ||
| "numpy >= 1.18", |
There was a problem hiding this comment.
Is this because we need the numpy C header files for the build with pybind11?
| line-length = 110 | ||
| target-version = ["py38"] | ||
|
|
||
| [tool.isort] |
There was a problem hiding this comment.
Oh, we hadn't run isort or black before. That explains the failures. Please fix the formatting problems.
mwittgen
force-pushed
the
tickets/DM-35347
branch
2 times, most recently
from
3c945a0
to
6aa91cf
Compare
mwittgen
force-pushed
the
tickets/DM-35347
branch
from
f01f86e
to
4b97dad
Compare
|
Reordered commits to have all black/isort changes in one. Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.