Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35587: Change HEALPix backend from healpy to hpgeom #47

Merged
merged 2 commits into from Jul 21, 2022
Merged

DM-35587: Change HEALPix backend from healpy to hpgeom #47

merged 2 commits into from Jul 21, 2022

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Jul 18, 2022

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

PaulPrice
PaulPrice approved these changes Jul 20, 2022
View reviewed changes
Copy link

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should squash the "Fix black and isort" commits into the other two, but at least squash the two "Fix black and isort" commits together.

python/lsst/sphgeom/_healpixPixelization.py
)
else:
vertices = np.array([[v.x(), v.y(), v.z()] for v in _poly.getVertices()])
pixels = hp.query_polygon(nside, vertices, inclusive=False, nest=True)
raise ValueError("Invalid region.")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raise ValueError(f"Unrecognized region class: {type(region)}")

@erykoff erykoff merged commit b5d12ff into main Jul 21, 2022
@erykoff erykoff deleted the tickets/DM-35587 branch July 21, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulPrice PaulPrice PaulPrice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erykoff @PaulPrice