DM-35894: numpy.distutils requires pinning setuptools<65 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwittgen
force-pushed
the
tickets/DM-35894
branch
from
42c3b00
to
c4bc4de
Compare
timj
approved these changes
Aug 15, 2022
.github/workflows/build.yaml
Outdated
| @@ -54,7 +54,7 @@ jobs: | |||
|
|
|||
| - name: Install dependencies | |||
| run: | | |||
| pip install --upgrade setuptools wheel build | |||
| pip install --upgrade "setuptools<65" "flake8<5" wheel build | |||
There was a problem hiding this comment.
Is this flake8 pin needed here? No tests are run.
mwittgen
force-pushed
the
tickets/DM-35894
branch
from
c4bc4de
to
7d3df76
Compare
pin flake8 < 5, required by pytest
mwittgen
force-pushed
the
tickets/DM-35894
branch
from
7d3df76
to
39a6af3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes